Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export createDomVisualElement #2648

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

o-alexandrov
Copy link

Currently, it's impossible to create a custom FeatureBundle (smaller version of domAnimation) because createDomVisualElement is not exported.

By exporting createDomVisualElement, users would then be able to create a smaller FeatureBundle, for example:

export default {
  renderer: createDomMotionComponent,
  ...animations, // `animations` variable is already exposed
} satisfies FeatureBundle

@o-alexandrov
Copy link
Author

@mattgperry could you please review the PR?

@o-alexandrov o-alexandrov changed the title Add ability to create a custom FeatureBundle Export createDomVisualElement May 7, 2024
@o-alexandrov
Copy link
Author

This PR is literally a one line code change which only exports a single variable that unblocks all use cases with slimmer LazyMotion.

@mattgperry could you please merge?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant