Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow user input node content as HtmlElement #129

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

allow user input node content as HtmlElement #129

wants to merge 1 commit into from

Conversation

Jim-JZ-Chen
Copy link

so user can better modifier the node content

@Jim-JZ-Chen
allow user input node content as HtmlElement
ffc99b4 
so user can better modifier the node content
@fperucic
Copy link
Owner

ok,
please use this.nodeInnerHTML instanceof HTMLElement instead of typeof this.nodeInnerHTML === "string" before using appendChild

We can merge when you make that change.

cheers

@fperucic
Copy link
Owner

and it would be nice to add the newly added options to the documentation branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Jim-JZ-Chen @fperucic