Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: transaction pagination #444

Open
wants to merge 1 commit into
base: release/v1.9
Choose a base branch
from

Conversation

gfyrag
Copy link
Collaborator

@gfyrag gfyrag commented May 24, 2023

No description provided.

@gfyrag gfyrag force-pushed the fix/transaction-pagination branch 4 times, most recently from 2da4fe1 to 39c6ddf Compare May 24, 2023 15:41
@codecov
Copy link

codecov bot commented May 24, 2023

Codecov Report

Merging #444 (9f23170) into release/v1.9 (a9c6a77) will increase coverage by 0.43%.
The diff coverage is 89.69%.

@@               Coverage Diff                @@
##           release/v1.9     #444      +/-   ##
================================================
+ Coverage         69.21%   69.65%   +0.43%     
================================================
  Files                95       95              
  Lines              6507     6544      +37     
================================================
+ Hits               4504     4558      +54     
+ Misses             1623     1607      -16     
+ Partials            380      379       -1     
Impacted Files Coverage Δ
pkg/api/controllers/transaction_controller.go 73.30% <50.00%> (+2.38%) ⬆️
pkg/storage/sqlstorage/transactions.go 82.35% <78.57%> (+0.74%) ⬆️
pkg/storage/sqlstorage/pagination_column.go 88.37% <88.37%> (ø)
pkg/ledger/storage.go 98.15% <91.89%> (-1.85%) ⬇️
pkg/api/internal/testing.go 88.88% <100.00%> (ø)
pkg/storage/sqlstorage/aggregations.go 54.65% <100.00%> (ø)

... and 1 file with indirect coverage changes

@gfyrag gfyrag force-pushed the fix/transaction-pagination branch from 39c6ddf to 9f23170 Compare May 24, 2023 15:49
@gfyrag gfyrag requested a review from flemzord as a code owner May 24, 2023 15:49
@gfyrag gfyrag requested a review from altitude May 24, 2023 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant