-
-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Symfony 6.4 #3588
Merged
Merged
Symfony 6.4 #3588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carakas
force-pushed
the
symfony7
branch
2 times, most recently
from
November 30, 2023 13:02
e9418e5
to
24c142a
Compare
tijsverkoyen
previously approved these changes
Nov 30, 2023
carakas
force-pushed
the
symfony7
branch
7 times, most recently
from
December 2, 2023 16:19
f6858b3
to
1514ae2
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## fork6 #3588 +/- ##
============================================
+ Coverage 41.92% 42.66% +0.74%
- Complexity 2674 2733 +59
============================================
Files 408 412 +4
Lines 10551 10759 +208
============================================
+ Hits 4423 4590 +167
- Misses 6128 6169 +41
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
They work fine locally
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type
Pull request description
I've updated the packages to 6.4, if we want to do 7 the minimum PHP version would be 8.2, should we bump to 8.2?
I'll do Symfony 7 later, still waiting for some dependencies to update and not sure how long that will take yet, symfony 6.4 is the same as 7, just with deprecation warnings