Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symfony 6.4 #3588

Merged
merged 7 commits into from
Dec 2, 2023
Merged

Symfony 6.4 #3588

merged 7 commits into from
Dec 2, 2023

Conversation

carakas
Copy link
Member

@carakas carakas commented Nov 30, 2023

Type

  • Enhancement

Pull request description

I've updated the packages to 6.4, if we want to do 7 the minimum PHP version would be 8.2, should we bump to 8.2?

I'll do Symfony 7 later, still waiting for some dependencies to update and not sure how long that will take yet, symfony 6.4 is the same as 7, just with deprecation warnings

@carakas carakas requested a review from a team as a code owner November 30, 2023 00:53
@carakas carakas changed the base branch from master to fork6 November 30, 2023 00:53
webpack.config.js Outdated Show resolved Hide resolved
@carakas carakas force-pushed the symfony7 branch 2 times, most recently from e9418e5 to 24c142a Compare November 30, 2023 13:02
tijsverkoyen
tijsverkoyen previously approved these changes Nov 30, 2023
@carakas carakas force-pushed the symfony7 branch 7 times, most recently from f6858b3 to 1514ae2 Compare December 2, 2023 16:19
Copy link

codecov bot commented Dec 2, 2023

Codecov Report

Attention: 250 lines in your changes are missing coverage. Please review.

Comparison is base (79257dc) 41.92% compared to head (8c20c7d) 42.66%.
Report is 20 commits behind head on fork6.

Files Patch % Lines
src/Core/Domain/Header/Meta/MetaCollection.php 38.02% 44 Missing ⚠️
...Modules/Frontend/Domain/Twig/FrontendExtension.php 37.83% 23 Missing ⚠️
...odules/Pages/Domain/Revision/Form/RevisionType.php 0.00% 17 Missing ⚠️
src/Core/Domain/Header/Header.php 42.10% 11 Missing ⚠️
src/Core/Domain/Header/ContentTitle.php 9.09% 10 Missing ⚠️
...rm/Validator/UniqueDataTransferObjectValidator.php 0.00% 8 Missing ⚠️
src/Core/Domain/Header/Meta/MetaCustom.php 0.00% 7 Missing ⚠️
src/Modules/Frontend/Domain/Meta/MetaType.php 0.00% 7 Missing ⚠️
...dules/Backend/Controller/BackendAjaxController.php 0.00% 6 Missing ⚠️
...c/Modules/Backend/Controller/BackendController.php 0.00% 6 Missing ⚠️
... and 42 more
Additional details and impacted files
@@             Coverage Diff              @@
##              fork6    #3588      +/-   ##
============================================
+ Coverage     41.92%   42.66%   +0.74%     
- Complexity     2674     2733      +59     
============================================
  Files           408      412       +4     
  Lines         10551    10759     +208     
============================================
+ Hits           4423     4590     +167     
- Misses         6128     6169      +41     
Flag Coverage Δ
functional 23.97% <19.72%> (+0.25%) ⬆️
installer 27.54% <23.66%> (+0.25%) ⬆️
unit 0.88% <11.60%> (+0.82%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

They work fine locally
@carakas carakas merged commit 05e3080 into forkcms:fork6 Dec 2, 2023
14 checks passed
@carakas carakas deleted the symfony7 branch December 2, 2023 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants