Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix password strength indicator not working during install #3583

Merged

Conversation

carakas
Copy link
Member

@carakas carakas commented Nov 26, 2023

Type

  • Non critical bugfix

Resolves the following issues

The password strength indicator didn't work anymore during the installer

Pull request description

I've also added the new toggle password field while I was at it

@carakas carakas added this to the 6.0.0 milestone Nov 26, 2023
@carakas carakas requested a review from a team as a code owner November 26, 2023 15:34
Copy link

codecov bot commented Nov 26, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (55be30e) 41.92% compared to head (805805c) 41.92%.

Files Patch % Lines
...er/Domain/Authentication/InstallerPasswordType.php 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##              fork6    #3583   +/-   ##
=========================================
  Coverage     41.92%   41.92%           
  Complexity     2674     2674           
=========================================
  Files           408      408           
  Lines         10551    10551           
=========================================
  Hits           4423     4423           
  Misses         6128     6128           
Flag Coverage Δ
functional 23.71% <0.00%> (ø)
installer 27.29% <0.00%> (ø)
unit 0.05% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@carakas carakas merged commit 59236eb into forkcms:fork6 Nov 27, 2023
13 of 14 checks passed
@carakas carakas deleted the fix-password-strength-during-installer branch November 27, 2023 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants