Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ci pipeline fixes #3578

Merged
merged 37 commits into from Dec 1, 2023
Merged

Ci pipeline fixes #3578

merged 37 commits into from Dec 1, 2023

Conversation

bjorvack
Copy link
Contributor

Type

  • Enhancement

Resolves the following issues

Fixes ci pipelines

@bjorvack bjorvack requested a review from a team as a code owner November 16, 2023 17:10
Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Attention: 100 lines in your changes are missing coverage. Please review.

Comparison is base (0527d15) 42.76% compared to head (166ea0c) 42.66%.

Files Patch % Lines
...odules/Pages/Domain/Revision/Form/RevisionType.php 0.00% 17 Missing ⚠️
...rm/Validator/UniqueDataTransferObjectValidator.php 0.00% 8 Missing ⚠️
...dules/Backend/Controller/BackendAjaxController.php 0.00% 6 Missing ⚠️
...c/Modules/Backend/Controller/BackendController.php 0.00% 6 Missing ⚠️
...Extensions/Backend/Actions/ThemeTemplateExport.php 0.00% 6 Missing ⚠️
.../Modules/Frontend/Domain/Block/BlockRepository.php 0.00% 6 Missing ⚠️
...ation/Domain/Translation/TranslationDomainType.php 0.00% 6 Missing ⚠️
...tionalisation/Backend/Actions/TranslationIndex.php 0.00% 5 Missing ⚠️
src/Modules/Pages/Backend/Actions/PageAdd.php 0.00% 5 Missing ⚠️
...les/Extensions/Domain/Module/ModuleInformation.php 0.00% 4 Missing ⚠️
... and 16 more
Additional details and impacted files
@@             Coverage Diff              @@
##              fork6    #3578      +/-   ##
============================================
- Coverage     42.76%   42.66%   -0.11%     
  Complexity     2733     2733              
============================================
  Files           412      412              
  Lines         10689    10759      +70     
============================================
+ Hits           4571     4590      +19     
- Misses         6118     6169      +51     
Flag Coverage Δ
functional 23.97% <20.14%> (+<0.01%) ⬆️
installer 27.54% <17.16%> (-0.07%) ⬇️
unit 0.88% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

.stylelintignoe Outdated Show resolved Hide resolved
src/Modules/Backend/templates/base/formTheme.html.twig Outdated Show resolved Hide resolved
src/Modules/Frontend/templates/base/Head.html.twig Outdated Show resolved Hide resolved
.stylelintrc Outdated Show resolved Hide resolved
phpcs.xml.dist Outdated Show resolved Hide resolved
phpcs.xml.dist Outdated Show resolved Hide resolved
src/Core/Ruleset/TwigcsForkRuleset.php Outdated Show resolved Hide resolved
phpcs-report.xml Outdated Show resolved Hide resolved
src/Themes/Fork/templates/Frontend/base/Head.html.twig Outdated Show resolved Hide resolved
src/Themes/Fork/templates/Frontend/base/Footer.html.twig Outdated Show resolved Hide resolved
src/Modules/Frontend/templates/base/Head.html.twig Outdated Show resolved Hide resolved
src/Modules/Backend/templates/base/macros.html.twig Outdated Show resolved Hide resolved
src/Modules/Backend/templates/base/header.html.twig Outdated Show resolved Hide resolved
src/Modules/Backend/templates/base/head.html.twig Outdated Show resolved Hide resolved
src/Modules/Backend/templates/base/head.html.twig Outdated Show resolved Hide resolved
.stylelintignore Outdated Show resolved Hide resolved
.stylelintrc Outdated Show resolved Hide resolved
composer.lock Show resolved Hide resolved
src/Core/assets/js/Components/Controls.js Show resolved Hide resolved
src/Modules/Pages/templates/Frontend/Navigation.html.twig Outdated Show resolved Hide resolved
@carakas carakas marked this pull request as draft November 24, 2023 22:22
tijsverkoyen
tijsverkoyen previously approved these changes Nov 30, 2023
@tijsverkoyen tijsverkoyen changed the title WIP: Ci pipeline fixes Ci pipeline fixes Nov 30, 2023
@carakas carakas marked this pull request as ready for review December 1, 2023 18:44
@carakas carakas merged commit f55ed17 into fork6 Dec 1, 2023
12 of 15 checks passed
@carakas carakas deleted the ci-pipeline-fixes branch December 1, 2023 18:45
@carakas carakas added this to the 6.0.0 milestone Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants