Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Fork6 blog #3576

Open
wants to merge 24 commits into
base: fork6
Choose a base branch
from
Open

[WIP] Fork6 blog #3576

wants to merge 24 commits into from

Conversation

davysumo
Copy link
Contributor

  • Enhancement

Resolves the following issues

Basic implementation of the old Blog module, some things don't completely work yet because more changes are needed to fork-6 core

@davysumo davysumo requested a review from a team as a code owner November 14, 2023 12:23
@carakas carakas self-assigned this Nov 17, 2023
Copy link

codecov bot commented Dec 17, 2023

Codecov Report

Attention: 752 lines in your changes are missing coverage. Please review.

Comparison is base (528d702) 46.68% compared to head (3dbf3d7) 43.81%.

Files Patch % Lines
.../Blog/Domain/ModuleSettings/ModuleSettingsType.php 0.00% 133 Missing ⚠️
src/Modules/Blog/Domain/Article/ArticleType.php 0.00% 114 Missing ⚠️
.../Modules/Blog/Domain/Article/ArticleRepository.php 0.00% 86 Missing ⚠️
src/Modules/Blog/Domain/Article/Article.php 0.00% 48 Missing ⚠️
src/Modules/Blog/Installer/BlogInstaller.php 0.00% 47 Missing ⚠️
...odules/Blog/Domain/Category/CategoryRepository.php 0.00% 42 Missing ⚠️
src/Modules/Blog/Domain/Category/CategoryType.php 0.00% 39 Missing ⚠️
src/Modules/Blog/Domain/Category/Category.php 0.00% 26 Missing ⚠️
...main/Article/Command/ArticleDataTransferObject.php 0.00% 23 Missing ⚠️
src/Modules/Blog/Frontend/Actions/Detail.php 0.00% 19 Missing ⚠️
... and 23 more
Additional details and impacted files
@@             Coverage Diff              @@
##              fork6    #3576      +/-   ##
============================================
- Coverage     46.68%   43.81%   -2.87%     
- Complexity     2854     2978     +124     
============================================
  Files           439      471      +32     
  Lines         11265    12023     +758     
============================================
+ Hits           5259     5268       +9     
- Misses         6006     6755     +749     
Flag Coverage Δ
functional 27.53% <0.52%> (-1.80%) ⬇️
installer 24.93% <1.05%> (-1.60%) ⬇️
unit 0.79% <0.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants