-
-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
495 default editorjs blocks #3574
495 default editorjs blocks #3574
Conversation
prep for image selector integration
Codecov ReportAttention:
📢 Thoughts on this report? Let us know! |
@@ -0,0 +1,26 @@ | |||
<script> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this test component needed?
if (vueApp) { | ||
const app = createApp() | ||
// global component | ||
app.component('TestComponent', TestComponent) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this test component needed? Or is this some debug-code for the media-library?
@@ -3,6 +3,8 @@ | |||
import * as bootstrap from 'bootstrap/dist/js/bootstrap.js' | |||
import 'select2/dist/js/select2.full' | |||
import 'flatpickr' | |||
import { createApp } from 'vue' | |||
import TestComponent from './Components/TestComponent.vue' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this needed?
@@ -31,19 +31,26 @@ | |||
.ce-wrapper-label { | |||
color: $gray-700; | |||
margin-bottom: 0; | |||
padding-right: 1rem; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't there a bootstrap variable that makes sense and can be used.
import TextImageBlock from './Blocks/TextImageBlock' | ||
import TextColumnBlock from './Blocks/TextColumnBlock' | ||
import { createApp } from 'vue' | ||
import TestComponent from '../../../../../Backend/assets/Backend/webpack/js/Components/TestComponent.vue' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this needed?
text2: data.text2 | ||
} | ||
|
||
console.log('data block: ', data) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Debug code?
render () { | ||
// wrapper | ||
const wrapper = this._make('div', this.CSS.wrapper) | ||
// wrapper.classList.add(this.CSS.alignment[this.data.alignment]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Debug code?
imagePosition: (Object.values(this.imagePositions).includes(data.imagePosition) && data.imagePosition) || this.defaultImagePosition | ||
} | ||
|
||
console.log('data block: ', data) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Debug code?
onActivate: () => { | ||
this.data.imagePosition = 'left' | ||
this.block.dispatchChange() | ||
console.log(this.data.imagePosition) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Debug code?
onActivate: () => { | ||
this.data.imagePosition = 'right' | ||
this.block.dispatchChange() | ||
console.log(this.data.imagePosition) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Debug code?
Closing for now since we'll try a different editor |
Type
Pull request description
Add editorjs plugins and additional custom blocks