Add ToggleSecret to backend scripts #3560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carakas
requested changes
Sep 20, 2023
src/Modules/Backend/assets/Backend/webpack/js/Components/ToggleSecret.js
Outdated
Show resolved
Hide resolved
|
Just an idea. So discuss: Wouldn't it be more logical to have this as a Symfony Form Type? So the developer does not need to remember to add the needed JS, but it is done automatically? |
|
Form type with this logic built is is a good idea |
|
@tijsverkoyen Form type added |
Codecov ReportAttention:
📢 Thoughts on this report? Let us know!. |
added 2 commits
October 11, 2023 12:25
Also move logic from button and input to input-group
tijsverkoyen
approved these changes
Oct 11, 2023
carakas
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type
Pull request description
Adds a script to toggle password/text input