Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Open Redirect issue #3547

Merged
merged 1 commit into from
Apr 14, 2023
Merged

Fix Open Redirect issue #3547

merged 1 commit into from
Apr 14, 2023

Conversation

tijsverkoyen
Copy link
Member

Fix an open redirect issue

Prevent redirect to external websites with a crafted url

See Unvalidated Redirects and Forwards Cheat Sheet for more information on Open Redirect

Fix an open redirect issue

Prevent redirect to external websites with a crafted url

See [Unvalidated Redirects and Forwards Cheat Sheet](https://cheatsheetseries.owasp.org/cheatsheets/Unvalidated_Redirects_and_Forwards_Cheat_Sheet.html) for more information on Open Redirect
@codecov
Copy link

codecov bot commented Apr 7, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (1b0d36c) 27.88% compared to head (bada778) 27.88%.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #3547   +/-   ##
=========================================
  Coverage     27.88%   27.88%           
  Complexity     8151     8151           
=========================================
  Files           575      575           
  Lines         30714    30714           
=========================================
  Hits           8565     8565           
  Misses        22149    22149           
Flag Coverage Δ
functional 23.79% <100.00%> (ø)
installer 3.84% <0.00%> (ø)
unit 7.69% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Frontend/Core/Engine/Url.php 61.53% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@carakas carakas merged commit 25bea7d into master Apr 14, 2023
18 checks passed
@carakas carakas deleted the tijsverkoyen-open-redirect-issue branch April 14, 2023 08:39
@carakas carakas added this to the 5.11.2 milestone Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants