Fixed php 8.0 support #3538
Merged
Fixed php 8.0 support #3538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacob-v-dam
force-pushed
the
upgrade-package-for-php-8
branch
4 times, most recently
from
b26c559
to
e4b1159
Compare
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #3538 +/- ##
============================================
- Coverage 27.88% 27.80% -0.09%
- Complexity 8152 8187 +35
============================================
Files 575 576 +1
Lines 30716 30799 +83
============================================
- Hits 8565 8563 -2
- Misses 22151 22236 +85
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
jacob-v-dam
force-pushed
the
upgrade-package-for-php-8
branch
2 times, most recently
from
c5feaa4
to
246579d
Compare
carakas
requested changes
Feb 20, 2023
jacob-v-dam
force-pushed
the
upgrade-package-for-php-8
branch
from
b55a5fc
to
9b01216
Compare
added 8 commits
July 25, 2023 19:10
jacob-v-dam
force-pushed
the
upgrade-package-for-php-8
branch
from
9b01216
to
5ff3cff
Compare
jacob-v-dam
force-pushed
the
upgrade-package-for-php-8
branch
2 times, most recently
from
b02fc52
to
98b2284
Compare
jacob-v-dam
force-pushed
the
upgrade-package-for-php-8
branch
from
98b2284
to
bb8e7d6
Compare
jacob-v-dam
force-pushed
the
upgrade-package-for-php-8
branch
from
3fa3791
to
e23e330
Compare
|
Thanks for updating @jacob-v-dam, I'll review it this weekend |
That would be perfect! The next step is to jump to Symfony 5.4 which is LTS for now. |
carakas
approved these changes
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type
Resolves the following issues
Adds PHP 8.0 support. PHP 7.1 is not supported anymore.
Pull request description
Upgrade packages and code to support PHP 7.4 and PHP 8.0. PHP 7.1 is not supported anymore.