WIP: 405 page add block modal #3454
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## restructure-core #3454 +/- ##
======================================================
- Coverage 32.81% 32.59% -0.22%
- Complexity 8724 8834 +110
======================================================
Files 651 658 +7
Lines 32106 32537 +431
======================================================
+ Hits 10534 10605 +71
- Misses 21572 21932 +360
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type
Resolves the following issues
/
Pull request description
This PR is an attempt to solve #3235, but isn't done. I've moved the original JSON content into a hidden field and made an attempt to move it back into the editor textarea's value property when a cancel button is clicked (as discussed in the last comment of the linked issue) but this doesn't seem to work. I figured I have to either reload the EditorJS instance to parse the old content I've put back, or somehow revert the AJAX call that is made by? Maybe @carakas could take a look and see where we go from here?