Partly fixed deprecations of Twig #2777 #2801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carakas
reviewed
Apr 24, 2019
| * @param string $app | ||
| */ | ||
| public static function addFilters(Twig_Environment $twig, string $app): void |
There was a problem hiding this comment.
is this change backwards compatible?
There was a problem hiding this comment.
It's definitely not backward compatible
But I've checked the usage of TwigFilters, that only happens in the Frontend/Backend Engine
And both are rewritten to pass the new Twig\Environment class
Do extensions call the Frontend/Backend Engine them self?
There was a problem hiding this comment.
Btw, I forgot to mention that I've done some random filter tests after the Twig changes and it worked for me so far
carakas
changed the base branch from
restructure-core
to
merge-fork-6-prs-in-restructure-core
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type
Resolves the following issues
Partly fixes #2777
Pull request description
I'm not done with all deprecations, some of them are a bit harder, like
User Deprecated: The "Symfony\Bridge\Twig\Extension\FormExtension" class implements "Twig\Extension\InitRuntimeInterface" that is deprecated since Twig 2.7, to be removed in 3.0.