Page add block modal cancel button

[Katrienvh]

Feature Request

Q	A
New Feature	no
RFC	no
BC Break	no

Summary

Before the upgrade to this modal with the new editor it was possible to cancel the modal or close it with the icon at the top. The cancel button and the close icon should cancel the actions. Now we only can 'save'. There is no other action.

We need a close/cancel button again.

[carakas]

The reason why there isn't one at the moment is that you are working directly in the form. If you make a close button you'll need to write extra js to make sure the content that was there before you made changes is placed back

[Katrienvh]

Well that's not a great reason to not add it I my eyes? Now it's not use friendly that there is no possibility to go back, cancel or close.

[carakas]

I didn't say it shouldn't be there.
I didn't add it while making it because there was no time left to implement this properly. Adding a close button that will still save the content of that part of the page would have been even more confusing

[Katrienvh]

I see, it was not clear to me whether it was an argument for or against the issue. So you agree that it should be added?

[carakas]

I just added that comment there to prevent somebody just adding a close button without the extra functionality that is needed.
Yes, I think it would indeed be more user-friendly to add that

[tijsverkoyen]

Internal reference: https://app.activecollab.com/108877/projects/62?modal=Task-116436-62

[sanderdlm]

@carakas I haven't been able to find a good solution for this. My idea was to hook into the Bootstrap modal shown event, use the save method of the editor inside the modal to get the initial JSON data and store it in a variable. On cancel/close, the JSON inside that variable could be restored instead of whatever the actual editor output is. I wasted quite a bit of time trying to work with the editor and new blocks system, but I haven't been able to get it all to work. Maybe we should have a call about this so you can show me around in the editor code?

[sanderdlm]

@carakas have you been able to take a look at this? Do you think it should still be on the roadmap for restructure core?

[carakas]

Not my priority now, currently focused on symfony 6