Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #33 #34

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix #33 #34

wants to merge 1 commit into from

Conversation

enbyted
Copy link

@enbyted enbyted commented Feb 1, 2015

Reconnect logic is now disabled when disconnect is by request (call to .end() or .destroy()).
This is not tested though, I don't have time for that. I may have missed some place where reconnect logic should be enabled back ( .retry.closed set to false ).

Reconnection logic is now disabled when disconnect is by request (call to .end() or .destroy()).
@indexzero
Copy link
Member

Would be accepted with tests. Otherwise will wait until someone with commit access has the time to write tests, which could be several months.

@enbyted
Copy link
Author

enbyted commented Feb 2, 2015

Well for me it could also be several months, when I'd have some time I'll
look into it, but no promises there.

Pozdrawiam
Bartosz Grabias
+48 793669953

2015-02-02 18:15 GMT+01:00 Charlie Robbins notifications@github.com:

Would be accepted with tests. Otherwise will wait until someone with
commit access has the time to write tests, which could be several months.


Reply to this email directly or view it on GitHub
#34 (comment).

@AlmirKadric
Copy link

This PR doesn't completely solve the issue. In the case where the retry timeout has already been created, this will still end up throwing. I have a PR coming soon which will fix this issue and a bunch of others I found getting nssocket ready for my own use.

EDIT: Take a look at #41

@andrew-aladev
Copy link

andrew-aladev commented Oct 10, 2016

@AlmirKadric +1

We should guard both prototype.reconnect and tryReconnect with this.retry.closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants