fix: preserve xml comments in decomposed files #1288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillieRuemmele
approved these changes
Apr 19, 2024
QA Notes✅ back out |
WillieRuemmele
approved these changes
Apr 30, 2024
QA Notes✅ : original QA |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
preserves xml comments for decomposed metadata (we do xml => json , then merge in json, then json => xml). fast-xml-parser was stripping out comments when converting to json. this PR sets a comments property so that the converted json includes the comment (in a special field) and sets the same prop on the xmlBuilder so that the comment gets back into the xml.
What issues does this PR fix or reference?
@W-15544382@
forcedotcom/cli#2830