[ BUG ] Assistant not working when creating local file links in markdown #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution! It looks like @Ramalingam0431 is an internal user so signing the CLA is not required. However, we need to confirm this. |
gagandeepSf
reviewed
Oct 16, 2023
| ]; | ||
|
|
||
| const customPlugins = [ | ||
| {label: '::include', insertText: new SnippetString(`\n::include{src="$1"}\n`)}, |
There was a problem hiding this comment.
@Ramalingam0431 I think, there is some prettier setting enable which is formatting all the files.
gagandeepSf
reviewed
Oct 16, 2023
| ) | ||
| ); | ||
| //replace the entire previously typed path by setting the range to start from the first text after "(" | ||
| const replacementStart = text.indexOf("(") + 1; |
There was a problem hiding this comment.
could you check if text could be "" or null in text.indexOf("(") + 1;
gagandeepSf
reviewed
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title : Assistant not working when creating local file links in markdown
Introduction: This PR aims to address an issue where the assistant incorrectly handles local file links in Markdown, causing them to malfunction.
Changes Made: I have made modifications to the assistant's behavior when creating local file links. Now, when a local file is selected from the dropdown, the link text will correctly display only the selected filename, without appending any previously typed characters.
Benefits/Impact: Users will experience improved functionality when creating local file links in Markdown documents. The assistant will provide the expected behavior, making the process more intuitive and reliable.
Related Issues: None