feat: migrate from @salesforce/core v6 -> v7 #5556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…estSetup in imports
…core when undefined
daphne-sfdc
force-pushed
the
daphne/core-v6-v7
branch
from
a6515e0
to
45c561a
Compare
…spaceContextUtil.test.ts
…ontextUtil.test.ts
peternhale
approved these changes
Apr 29, 2024
| @@ -4,6 +4,7 @@ | |||
| * Licensed under the BSD 3-Clause license. | |||
| * For full license text, see LICENSE.txt file in the repo root or https://opensource.org/licenses/BSD-3-Clause | |||
| */ | |||
| import { ListMetadataQuery } from '@jsforce/jsforce-node/lib/api/metadata'; | |||
There was a problem hiding this comment.
@daphne-sfdc can you check to see if this is exposed at the module level?
There was a problem hiding this comment.
It seems like ListMetadataQuery does exist at the top level but it refers to something else? I did have to change the import to import ListMetadataQuery from '@jsforce/jsforce-node' without the curly braces.
peternhale
approved these changes
Apr 29, 2024
| @@ -23,10 +23,10 @@ export const stopTelemetry = (): Promise<void> => { | |||
| return Promise.resolve(); | |||
| }; | |||
|
|
|||
| export interface TelemetryModelJson extends JsonMap { | |||
| export type TelemetryModelJson = JsonMap & { | |||
There was a problem hiding this comment.
@daphne-sfdc I don't believe JsonMap is necessary.
There was a problem hiding this comment.
@peternhale The double negative means you think it is necessary and what's currently there is fine? Or did you actually mean JSONMap is not necessary?
gbockus-sf
reviewed
Apr 29, 2024
| @@ -5,12 +5,12 @@ | |||
| * For full license text, see LICENSE.txt file in the repo root or https://opensource.org/licenses/BSD-3-Clause | |||
| */ | |||
|
|
|||
| import { DescribeSObjectResult } from '@jsforce/jsforce-node'; | |||
There was a problem hiding this comment.
We already moved to jsforce-node! 🍠
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Migrates @salesforce/core from v6.7.4 -> v7.3.1
This upgrade means we are able to support Core v7 in our other dependencies, so the following dependencies are also migrated from Core v6 -> v7 in this PR:
Additional changes:
@salesforce/core/testSetupto use top-level importsworkspaceContextUtils.test.tsunit test to make it passWhat issues does this PR fix or reference?
@W-15472197@
Functionality Before
Extensions monorepo uses v6 of @salesforce/core
Functionality After
Extensions monrepo uses v7 of @salesforce/core, which means we are now able to pull in new features from our shared libraries