Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix handling of abstract methods in outline #5555

Merged
merged 3 commits into from
Apr 25, 2024

Conversation

peternhale
Copy link
Contributor

When document symbols are requested from the apex LS for an Apex class with abstract methods, it did not take into account an empty method body.

The LS update now handles this condition properly

@W-15593844@, #5553

Given the Apex class

public abstract class my {
    public my() {

    }
    public String s1() {
        return 's1';
    }

    public abstract String s2();
}

Functionality Before

Screenshot 2024-04-25 at 8 02 39 AM

Functionality After

Screenshot 2024-04-25 at 8 07 47 AM

@W-15593844@ patch apex LS to fix doc symbols for abstract methods
@peternhale peternhale requested a review from a team as a code owner April 25, 2024 14:08
@peternhale peternhale requested review from klewis-sfdc and mingxuanzhangsfdx and removed request for klewis-sfdc April 25, 2024 14:08
Copy link
Member

@mingxuanzhangsfdx mingxuanzhangsfdx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! LGTM

@diyer
Copy link
Collaborator

diyer commented Apr 25, 2024

Hi @peternhale , can we create a work item in our automation epic to have an end to end test for outline use case?

@peternhale peternhale merged commit 653c694 into develop Apr 25, 2024
12 checks passed
@peternhale peternhale deleted the phale/W-15593844-fix-outline branch April 25, 2024 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants