Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Use GITHUB_OUTPUT envvar instead of set-output command #5345

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
+17 −17
Open

ci: Use GITHUB_OUTPUT envvar instead of set-output command #5345

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
30a7f96
ci: Use GITHUB_OUTPUT envvar instead of set-output command
arunsathiya Jan 18, 2024
38c48d1
Quote envvar to match documentation
arunsathiya Jan 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/createReleaseBranch.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,11 +54,11 @@ jobs:
echo "Creating a ${{ github.event.inputs.releaseType || 'minor' }} release from branch release/v$(node -pe "require('./packages/salesforcedx-vscode/package.json').version")"
node scripts/create-release-branch.js
- id: result
run: echo "result=${{ job.status }}" >> $GITHUB_OUTPUT
run: echo "result=${{ job.status }}" >> "$GITHUB_OUTPUT"
- id: version
run: echo "version="$(node -pe "require('./packages/salesforcedx-vscode/package.json').version")"" >> $GITHUB_OUTPUT
run: echo "version="$(node -pe "require('./packages/salesforcedx-vscode/package.json').version")"" >> "$GITHUB_OUTPUT"
- id: branch
run: echo "branch=release/v${{ steps.version.outputs.version }}" >> $GITHUB_OUTPUT
run: echo "branch=release/v${{ steps.version.outputs.version }}" >> "$GITHUB_OUTPUT"
- run: echo "Release Version is ${{ steps.version.outputs.version }}"
- run: echo “Release Type is ${{ github.event.inputs.releaseType || 'minor' }}”
- run: echo “Release Branch is ${{ steps.branch.outputs.branch }}”
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/generateChangelog.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,4 +26,4 @@ jobs:
- name: Generate CHANGELOG
run: npm run changelog
- id: result
run: echo "result=${{ job.status }}" >> $GITHUB_OUTPUT
run: echo "result=${{ job.status }}" >> "$GITHUB_OUTPUT"
4 changes: 2 additions & 2 deletions .github/workflows/mergeReleaseBranch.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
ref: ${{ inputs.releaseBranch }}
- id: getReleaseVersion
run: |
echo "version="$(node -pe "require('./packages/salesforcedx-vscode/package.json').version")"" >> $GITHUB_OUTPUT
echo "version="$(node -pe "require('./packages/salesforcedx-vscode/package.json').version")"" >> "$GITHUB_OUTPUT"
- run: echo "Release Version is ${{ steps.getReleaseVersion.outputs.version }}"

get_main_version:
Expand All @@ -33,7 +33,7 @@ jobs:
ref: 'main'
- id: getMainVersion
run: |
echo "version="$(node -pe "require('./packages/salesforcedx-vscode/package.json').version")"" >> $GITHUB_OUTPUT
echo "version="$(node -pe "require('./packages/salesforcedx-vscode/package.json').version")"" >> "$GITHUB_OUTPUT"
- run: echo "Main Version is ${{ steps.getMainVersion.outputs.version }}"

merge-release-branch:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/publishBetaRelease.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ jobs:
steps:
- uses: actions/checkout@v3
- id: getVersion
run: echo "::set-output name=version::"$(node -pe "require('./packages/salesforcedx-vscode/package.json').version")""
run: echo "version="$(node -pe "require('./packages/salesforcedx-vscode/package.json').version")"" >> "$GITHUB_OUTPUT"
- run: echo "Release Version is ${{ steps.getVersion.outputs.version }}"

create_git_tag:
Expand Down Expand Up @@ -76,7 +76,7 @@ jobs:
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
- id: version
run: echo "version=${{ env.VERSION }}" >> $GITHUB_OUTPUT
run: echo "version=${{ env.VERSION }}" >> "$GITHUB_OUTPUT"

slack_notification:
if: ${{ always() }}
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/publishOpenVSX.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,15 +33,15 @@ jobs:
ref: 'main'
- id: getMainVersion
run: |
echo "version="$(node -pe "require('./packages/salesforcedx-vscode/package.json').version")"" >> $GITHUB_OUTPUT
echo "version="$(node -pe "require('./packages/salesforcedx-vscode/package.json').version")"" >> "$GITHUB_OUTPUT"
- run: echo "Main Version is ${{ steps.getMainVersion.outputs.version }}"
- id: getGusBuild
run: |
echo "gusBuild=${{ steps.getMainVersion.outputs.version }}" >> $GITHUB_OUTPUT
echo "gusBuild=${{ steps.getMainVersion.outputs.version }}" >> "$GITHUB_OUTPUT"
- run: echo "GUS BUILD is ${{ steps.getGusBuild.outputs.gusBuild }}"
- id: getScheduledBuild
run: |
echo "sfChangeCaseScheduleBuild=offcore.tooling.${{ steps.getMainVersion.outputs.version }}" >> $GITHUB_OUTPUT
echo "sfChangeCaseScheduleBuild=offcore.tooling.${{ steps.getMainVersion.outputs.version }}" >> "$GITHUB_OUTPUT"
- run: echo "SF_CHANGE_CASE_SCHEDULE_BUILD is ${{ steps.getScheduledBuild.outputs.sfChangeCaseScheduleBuild }}"\


Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/publishVSCode.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,15 +33,15 @@ jobs:
ref: 'main'
- id: getMainVersion
run: |
echo "version="$(node -pe "require('./packages/salesforcedx-vscode/package.json').version")"" >> $GITHUB_OUTPUT
echo "version="$(node -pe "require('./packages/salesforcedx-vscode/package.json').version")"" >> "$GITHUB_OUTPUT"
- run: echo "Main Version is ${{ steps.getMainVersion.outputs.version }}"
- id: getGusBuild
run: |
echo "gusBuild=${{ steps.getMainVersion.outputs.version }}" >> $GITHUB_OUTPUT
echo "gusBuild=${{ steps.getMainVersion.outputs.version }}" >> "$GITHUB_OUTPUT"
- run: echo "GUS BUILD is ${{ steps.getGusBuild.outputs.gusBuild }}"
- id: getScheduledBuild
run: |
echo "sfChangeCaseScheduleBuild=offcore.tooling.${{ steps.getMainVersion.outputs.version }}" >> $GITHUB_OUTPUT
echo "sfChangeCaseScheduleBuild=offcore.tooling.${{ steps.getMainVersion.outputs.version }}" >> "$GITHUB_OUTPUT"
- run: echo "SF_CHANGE_CASE_SCHEDULE_BUILD is ${{ steps.getScheduledBuild.outputs.sfChangeCaseScheduleBuild }}"\

ctc-open:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ jobs:
ref: 'main'
- id: getMainVersion
run: |
echo "version="$(node -pe "require('./packages/salesforcedx-vscode/package.json').version")"" >> $GITHUB_OUTPUT
echo "version="$(node -pe "require('./packages/salesforcedx-vscode/package.json').version")"" >> "$GITHUB_OUTPUT"
- run: echo "Main Version is ${{ steps.getMainVersion.outputs.version }}"

release:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/tagAndRelease.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ jobs:
git push origin develop
- id: complete
run: |
echo "status=complete" >> $GITHUB_OUTPUT
echo "status=complete" >> "$GITHUB_OUTPUT"
- id: finish
run: |
echo "VSCode Tag and Release Success"
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/testBuildAndRelease.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
ref: 'main'
- id: getMainVersion
run: |
echo "version="$(node -pe "require('./packages/salesforcedx-vscode/package.json').version")"" >> $GITHUB_OUTPUT
echo "version="$(node -pe "require('./packages/salesforcedx-vscode/package.json').version")"" >> "$GITHUB_OUTPUT"
- run: echo "Main Release Version is ${{ steps.getMainVersion.outputs.version }}"
build-and-test:
uses: ./.github/workflows/buildAndTest.yml
Expand Down