refactor: address feedback from yeoman update PR #476 #486
+151
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbockus-sf
commented
May 6, 2022
| reject(err); | ||
| }); | ||
| }); | ||
| await this.env.run(generatorNamespace, templateOptions); |
There was a problem hiding this comment.
same functionality with await/async
gbockus-sf
commented
May 6, 2022
| restore(); | ||
| }); | ||
|
|
||
| it('Should set the customInstallTask feature to false for the ProjectGenerator', () => { |
There was a problem hiding this comment.
went to add just this test, but then much us the file was uncovered so I went ahead and added some simple tests to cover the rest of the functionality.
smithgp
approved these changes
May 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?