feat: add analytics dashboard lwc templates #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smithgp
commented
May 20, 2021
| path.join(outputdir, componentname, `${componentname}.cmp`) | ||
| ), | ||
| {} | ||
| ); |
There was a problem hiding this comment.
These calls where all ending with a , (and not ; before, which, while valid, seemed a little weird. I updated to use a ;, which also fixed the formatting -- turn off whitespace diffs in the gear icon to see this a little better.
smithgp
force-pushed
the
gps/analytics-dashboard-lwc
branch
from
c914d59
to
0db5d2f
Compare
smithgp
commented
May 24, 2021
| | 'ApexUnitTest' | ||
| | 'ApexException' | ||
| | 'InboundEmailService'; | ||
| | 'DefaultApexClass' |
There was a problem hiding this comment.
The reformat in pre-commit did these whitespace changes here.
@W-9191596@
@W-9191596@
smithgp
force-pushed
the
gps/analytics-dashboard-lwc
branch
from
0db5d2f
to
71de51a
Compare
xyc
reviewed
May 26, 2021
and also use a hard-coded list on the options flag config for --template to match for consistency.
xyc
approved these changes
May 27, 2021
xyc
pushed a commit
that referenced
this pull request
Jun 1, 2021
* feat: support aura/lwc component templates @W-9191596@ * feat: analytics dashboard lwc templates @W-9191596@ * fix: update to union type on LightningComponentOptions and also use a hard-coded list on the options flag config for --template to match for consistency.
jag-j
pushed a commit
that referenced
this pull request
Jun 3, 2021
* feat: support aura/lwc component templates @W-9191596@ * feat: analytics dashboard lwc templates @W-9191596@ * fix: update to union type on LightningComponentOptions and also use a hard-coded list on the options flag config for --template to match for consistency.
xyc
pushed a commit
that referenced
this pull request
Jun 3, 2021
* feat: support aura/lwc component templates @W-9191596@ * feat: analytics dashboard lwc templates @W-9191596@ * fix: update to union type on LightningComponentOptions and also use a hard-coded list on the options flag config for --template to match for consistency.
jag-j
pushed a commit
that referenced
this pull request
Jun 3, 2021
* feat: support aura/lwc component templates @W-9191596@ * feat: analytics dashboard lwc templates @W-9191596@ * fix: update to union type on LightningComponentOptions and also use a hard-coded list on the options flag config for --template to match for consistency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
--templatewithforce:lighting:component:create:--helpdidn't list any available template names--templatewith any value (including the defaultDefaultLightningCmp) would produce an errorforce:lightning:component:createcommand to support multiple options for--templateanalyticsDashboardandanalyticsDashboardWithSteplwc templatesWhat issues does this PR fix or reference?
@W-9191596@
cc: @jimmydief