feat(tab): add removable variation #2869
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prudho
added
type/feat
lubber-de
reviewed
Aug 4, 2023
There was a problem hiding this comment.
Quick thoughts
- What about a lonely "+" icon inside a new (unbound/fake) tab to also add a new tab (optional). Would also need two new events "onAdd" and "onBeforeAdd" just like you implemented for remove
what to do if all tabs are closed.
I think it should be an (optional) restriction to keep at least 1 tab (or that setting can define how many tabs have to stay as minimum)
I'll try that on another PR ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR add the ability to remove a tab by clicking on an icon or programmaticaly. It works by adding the
removableclass to the desired tab headers or settingremovable: trueon initialization. Two new callbacks are implemented:onRemove(tabPath)when the tab is removed, andonBeforeRemove(tabPath), which allow cancelling the removal of the table by returningfalse. When removing a tab, it will move to the closest which is not disabled.For now i'll mark it as WIP, since there's some tests to do on nested tabs, and decide what to do if all tabs are closed.
Screenshot
Closes
#2521