Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration to Laravel 5.8 #50

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Conversation

leknoppix
Copy link

@leknoppix leknoppix commented May 8, 2019

I have test and this work.
The major problem is that Laravel 5.8 requires a php version higher than 7.1, so impossible to roolback in the tests

I think the best will be to let version v0.3.25 for laravel 5.7 and pass on a new version for Laravel 5.8 or higher

@dmongeau
Copy link
Member

dmongeau commented May 8, 2019

I will need to check this since I want to keep backward compatibility. I doubt it's not possible (even with the PHP minimum version).

@leknoppix
Copy link
Author

Php 7.1 is the minimal version for Laravel 5.8

@dmongeau
Copy link
Member

dmongeau commented May 8, 2019

Yes, but I have several project where it's the same and we just have to configure travis properly. The rest should work and stay the same

@leknoppix
Copy link
Author

leknoppix commented May 8, 2019

i have try on a old project who I upgrade on laravel 5.8 but i obtain an error.

Class 'Folklore\Image\ImageServiceProvider' not found

So, the code of class is not good, i continue my search.

EDIT, With 5.7, your plugin works

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants