Fixed jitter while walking and rotating at the same time. #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Made rotation smoother by buffering changes in rotation made by the on_mouse_motion callback, and adding them later in the update method. Updating the position and rotation at the same time removes the jittery which appears while walking and moving your sight simultaneously.
|
Tested and jitter is removed, but it appears this math is quite a bit more expensive now. I had consistently >60fps prior to testing, and have seen dips to ~28fps with the update on my, truthfully, borderline antiquated hardware. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug Description
The blocks on screen jitter when the player walks horizontally and rotates simultaneously.
Bug Reproduction
Walk to the side and rotate the camera at the same time.
Bug Cause
The bug is caused by a lack of synchronization between the
on_mouse_updatemethod, which updates the player rotation, and theupdatemethod, which updates the player position.Bug Fix
In the
on_mouse_updatemethod of theWindowclass, instead of immediately updating the player rotation, buffer the updates. Then, in theupdatemethod of the same class, update the player position and player rotation at the same time.