Fixed Issue #209: Walking through blocks at a 45 degree angle #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pspiworld
added a commit
to pspiworld/piworld
that referenced
this pull request
Oct 25, 2019
Fixed in Craft pull request fogleman#216 from usernamefreaks. Bug report: fogleman#209
ihalseide
reviewed
May 4, 2022
ihalseide
approved these changes
Nov 27, 2022
tsee
pushed a commit
to tsee/Craft
that referenced
this pull request
May 29, 2023
Fixed in Craft pull request fogleman#216 from usernamefreaks. Bug report: fogleman#209
tsee
pushed a commit
to tsee/Craft
that referenced
this pull request
Jun 2, 2023
Fixed in Craft pull request fogleman#216 from usernamefreaks. Bug report: fogleman#209
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to the issue we fixed: #209
The cause of the bug is that in the collide() function, it doesn't check whether the 4 diagonally neighboring blocks are obstacles. We added code that check for obstacles in these directions.