Implement Matomo Tag Manager Support #51
Conversation
* Add config flag for switching between Tag Manager Container and direct Tracking code * Don't check for window._mtm anymore -> use configuration * Remote unnecessary JsOptions / calls only for paq
* Separate templates * Include the Tag Manager code in the <head> tag
| return; | ||
| } | ||
| ?> | ||
| <script type="text/x-magento-init"> |
There was a problem hiding this comment.
what do you think? should we create an additional block (actually 2 additional blocks) or leave it like that?
|
@fnogatz Can you re-trigger travis :D ? |
|
Thanks for merging the latest main branch. |
|
Exactly 😞 Any idea how to solve this? According to the Travis CI documentation, apparently, there's no way to specify private environment variables in a way that's available for PRs coming from forks. I don't think it's a good idea to have just some credentials for the Magento repo in the composer config (as suggested in #52), as they might be copied by other projects etc. You don't want to have credentials in your |
* Use Fooman-mirror for Travis installation to avoid requiring credentials (see https://fooman.com/blog/no-authentication-needed-magento-2-mirror.html and #51) * Use --add-repository CLI flag to stick to fooman mirror * Stick to https://repo-magento-mirror.fooman.co.nz/ mirror on installation * Downgrade to composer v1 in Travis job matrix * Downgrade to composer v1 in Travis job matrix * Install dev-dependencies in 2nd step * Work around memory limit * Set composer version in environment variable * Use latest versions of 2.3.3, 2.3.4, and 2.3.5 * Remove pre-2.3.6 Magento versions from Travis CI matrix
|
Hello, Can perhaps a forecast be made as to when tag manager support for magento will be released? |
|
Hm how shall we proceed on that? The checks are now successful. |
|
Hello! Is there a chance this will be merged soon? |
|
Yes, @drabikowy - if I remember it correctly the configuration switch replaces the direct Matomo tracking with tag manager. It was implemented that way because we add Matomo tracking in the tag manager. The variables can be passed through, so it should be pretty straight forward easy to set this up. If you have a use case to support both, feel free to provide a modified pull request. |
|
poke can this eventually be merged and released ? |
No description provided.