fmt::sprintf(locale, ...) support - analog of snprintf_l() #3958
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fmtlib supports locale aware formatting, even with custom locales, but only in fmt::format(locale, ...)
This patch adds locale support to fmt::printf() functions family
Our application, Live Home 3D, has large amount of localized strings, all with printf-like specifiers, and we successfully used snprintf_l on Mac, iOS, Windows, but Android surprised us. Android has very rudimentary support of locales in libc, only "C" and "UTF-8". Moreover, basic working horse function __vfprintf() uses nl_langinfo(RADIXCHAR) to obtain decimal_separator
and nl_langinfo() does simply case RADIXCHAR: result = "."; break; There are no xxxprintf_l() functions at all.
https://android.googlesource.com/platform/bionic/+/refs/heads/main/libc/stdio/vfprintf.cpp
https://android.googlesource.com/platform/bionic/+/refs/heads/main/libc/bionic/langinfo.cpp
Following test passed on Windows, macOS and most importantly - on Android