Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for PR #4726 #5200

Open
wants to merge 5 commits into
base: fg91/feat/log-links-show-while-pending
Choose a base branch
from

Conversation

fg91
Copy link
Member

@fg91 fg91 commented Apr 8, 2024

Add tests for PR #4726. As a separate PR because the PR is getting too long already.

The added tests test the fixes explained in this comment.

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Apr 8, 2024
@fg91 fg91 marked this pull request as draft April 8, 2024 21:53
@dosubot dosubot bot added the enhancement New feature or request label Apr 8, 2024
Copy link

codecov bot commented Apr 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.71%. Comparing base (d409b3b) to head (9be1964).

Additional details and impacted files
@@                            Coverage Diff                             @@
##           fg91/feat/log-links-show-while-pending    #5200      +/-   ##
==========================================================================
- Coverage                                   61.11%   60.71%   -0.40%     
==========================================================================
  Files                                         793      715      -78     
  Lines                                       51197    47272    -3925     
==========================================================================
- Hits                                        31288    28701    -2587     
+ Misses                                      17032    15873    -1159     
+ Partials                                     2877     2698     -179     
Flag Coverage Δ
unittests-datacatalog 69.31% <ø> (ø)
unittests-flyteadmin 58.91% <ø> (-0.05%) ⬇️
unittests-flytecopilot 17.79% <ø> (ø)
unittests-flytectl 68.31% <ø> (ø)
unittests-flyteidl 79.30% <ø> (ø)
unittests-flyteplugins 61.94% <ø> (ø)
unittests-flytepropeller 57.32% <ø> (ø)
unittests-flytestdlib ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fg91 fg91 force-pushed the fg91/feat/log-links-show-while-pending branch from d4b547d to dbc36a0 Compare April 17, 2024 19:07
@fg91 fg91 force-pushed the fg91/test/add-tests-pr-4726 branch from 374242b to f343ea7 Compare April 17, 2024 19:29
@fg91 fg91 force-pushed the fg91/feat/log-links-show-while-pending branch from dbc36a0 to 50e76c2 Compare May 23, 2024 20:45
fg91 added 4 commits May 24, 2024 10:38
… reason changes within the same phase

Signed-off-by: Fabio Graetz <fabiograetz@googlemail.com>
Signed-off-by: Fabio Graetz <fabiograetz@googlemail.com>
Signed-off-by: Fabio Graetz <fabiograetz@googlemail.com>
Signed-off-by: Fabio Graetz <fabiograetz@googlemail.com>
@fg91 fg91 force-pushed the fg91/test/add-tests-pr-4726 branch from 61d2799 to e4bada1 Compare May 24, 2024 17:41
@fg91 fg91 marked this pull request as ready for review May 24, 2024 17:47
@fg91 fg91 requested a review from eapolinario May 24, 2024 17:47
Signed-off-by: Fabio Graetz <fabiograetz@googlemail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant