New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for PR #4726 #5200
Open
fg91
wants to merge
5
commits into
fg91/feat/log-links-show-while-pending
Choose a base branch
from
fg91/test/add-tests-pr-4726
base: fg91/feat/log-links-show-while-pending
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add tests for PR #4726 #5200
fg91
wants to merge
5
commits into
fg91/feat/log-links-show-while-pending
from
fg91/test/add-tests-pr-4726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:L
This PR changes 100-499 lines, ignoring generated files.
label
Apr 8, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## fg91/feat/log-links-show-while-pending #5200 +/- ##
==========================================================================
- Coverage 61.11% 60.71% -0.40%
==========================================================================
Files 793 715 -78
Lines 51197 47272 -3925
==========================================================================
- Hits 31288 28701 -2587
+ Misses 17032 15873 -1159
+ Partials 2877 2698 -179
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
fg91
force-pushed
the
fg91/feat/log-links-show-while-pending
branch
from
April 17, 2024 19:07
d4b547d
to
dbc36a0
Compare
fg91
force-pushed
the
fg91/test/add-tests-pr-4726
branch
from
April 17, 2024 19:29
374242b
to
f343ea7
Compare
3 tasks
fg91
force-pushed
the
fg91/feat/log-links-show-while-pending
branch
from
May 23, 2024 20:45
dbc36a0
to
50e76c2
Compare
… reason changes within the same phase Signed-off-by: Fabio Graetz <fabiograetz@googlemail.com>
Signed-off-by: Fabio Graetz <fabiograetz@googlemail.com>
Signed-off-by: Fabio Graetz <fabiograetz@googlemail.com>
Signed-off-by: Fabio Graetz <fabiograetz@googlemail.com>
fg91
force-pushed
the
fg91/test/add-tests-pr-4726
branch
from
May 24, 2024 17:41
61d2799
to
e4bada1
Compare
Signed-off-by: Fabio Graetz <fabiograetz@googlemail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tests for PR #4726. As a separate PR because the PR is getting too long already.
The added tests test the fixes explained in this comment.