-
-
Notifications
You must be signed in to change notification settings - Fork 445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add 2 new customizable variables for tcl-nagelfar checker #1906
base: master
Are you sure you want to change the base?
Conversation
michalisv
commented
Sep 21, 2021
- flycheck-tcl-nagelfar-headers: allow definition of pre-created header files in order to support work on large projects where functions are spread over different files/directories and nagelfar might give false-positive "unknown command" errors
- flycheck-tcl-nagelfar-args: allow definition of additional arguments for nagelfire e.g. -Wunusedvar etc
1) flycheck-tcl-nagelfar-headers: allow definition of pre-created header files in order to support work on large projects where functions are spread over different files/directories and nagelfar might give false-positive "unknown command" errors 2) flycheck-tcl-nagelfar-args: allow definition of additional arguments for nagelfire e.g. -Wunusedvar etc
i had some problems with the previous PR & couldn't get the CLA signing to complete. Hopefully it is ok now. |
The changes look good, but your branch has to be rebased on top of the current |
@@ -12056,11 +12056,33 @@ See URL | |||
|
|||
(flycheck-def-config-file-var flycheck-chktexrc tex-chktex ".chktexrc") | |||
|
|||
(flycheck-def-args-var flycheck-tcl-nagelfar-args tcl-nagelfar | |||
:package-version '(flycheck . "0.32")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should say 35.0.
paths are relative to the file being checked." | ||
:type '(repeat (file :tag "Include file")) | ||
:safe #'flycheck-string-list-p | ||
:package-version '(flycheck . "0.32")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ditto.
Please add a changelog entry as well. |