Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improved conditions for plane symbol on plan page #8653

Merged
merged 3 commits into from May 19, 2024

Conversation

Saschl
Copy link
Member

@Saschl Saschl commented May 12, 2024

Fixes plane symbol on plan mode showing incorrectly before ppos is available.

Fixes #[issue_no]

Summary of Changes

Screenshots (if necessary)

References

Additional context

Discord username (if different from GitHub):

Testing instructions

  1. Start C&D, power up plane and select PLAN mode on ND
  2. Set all three ADIRS to NAV and wait for alignment.
  3. Plane symbol should not appear before alignment is completely finished.
  4. Check that the orientation and position of the symbol is correct.
  5. Verify the symbol moves and rotates correctly when taxiing and after takeoff.

How to download the PR for QA

Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, find and click on the PR Build tab
  4. Click on either flybywire-aircraft-a320-neo or flybywire-aircraft-a380-842 download link at the bottom of the page

@github-actions github-actions bot added this to 🟡 Code Review: Ready for Review in Quality Assurance May 12, 2024
@Saschl Saschl changed the title Fix/plan plane fix: improved conditions for plane symbol on plan page May 12, 2024
Quality Assurance automation moved this from 🟡 Code Review: Ready for Review to 🟣 QA Team Review: Ready to Test May 14, 2024
@LunakisDev
Copy link

Quality Assurance Trainee Report

Discord: LunakisLeaks
Object of testing: #8653
Tier of Testing : 1
Date: 16/5/2024

Testing Process:

  1. Spawned at LGAV in C&D state
  2. Started the aircraft
  3. Align of the ADIRS
  4. Set up FPLN PERF etc
  5. taxied around in the airport to verify the symbol moves and rotates correctly when taxiing
  6. Full flight to test the symbol in the air

Negatives:
N/A

Testing Results:
Passed

Conclusions:
LGTM

@2hwk 2hwk added this to the v0.12.0 milestone May 18, 2024
@Saschl Saschl merged commit 37f5601 into flybywiresim:master May 19, 2024
7 checks passed
Quality Assurance automation moved this from 🟣 QA Team Review: Ready to Test to ✔️ Done May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants