-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(a380x): Correct flap/slats positions #8651
base: master
Are you sure you want to change the base?
fix(a380x): Correct flap/slats positions #8651
Conversation
9064aa9
to
9c59c77
Compare
fbw-common/src/wasm/systems/systems/src/simulation/update_context.rs
Outdated
Show resolved
Hide resolved
(cherry picked from commit bf94a44)
826f3be
to
5877d39
Compare
@tracernz Reworked some bits, your comments should now be addressed |
@@ -210,7 +211,7 @@ impl SlatFlapControlComputer { | |||
if context.is_in_flight() | |||
&& (context.indicated_airspeed().get::<knot>() | |||
< Self::ALPHA_SPEED_LOCK_IN_AIRSPEED_THRESHOLD_KNOTS | |||
|| context.angle_of_attack().get::<degree>() | |||
|| adirs_output.angle_of_attack(1).value().get::<degree>() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should check the SSM before using the value. Should it just blindly always use ADR1, or should there be some selection logic to choose an ADR based on validity of the data/SSM?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, forgot about the SSM, didn't know how these are handled in the rust libs.
The selection logic for ADR data should be the same everywhere:
Median value if alle three operational,
mean if only two operational
don't use it of only one operational
But I haven't seen this selection logic implemented somewhere, and I don't think it makes sense to handle this on every consumer's side (nor do I have the Rust skills to implement a selector). I'll maybe go with the approach seen in air cond, which is chose the first one with valid SSM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The selection logic for ADR data should be the same everywhere:
No, many systems have different logic for specific reasons. You will have to implement whatever the computer you're implementing does.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just pushed the agreed selection logic (pick first one with valid data)
A380X only, no QA needed.
Summary of Changes
This should be an improvement to the current SFCC implementation for the A380X.
In scope:
Out of scope:
Screenshots (if necessary)
References
Additional context
No appropriate references for A380 FPPU, hence it's assumed the same FPPU as in the A320 is used.
Resulting FPPU angles:
Discord username (if different from GitHub): floridude
Testing instructions
How to download the PR for QA
Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.