Sebs/incompatible nom #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sebs/feature device selector
- changed return param order for bugreport - add pub to avoid clippy unused warnings
- config-rs depends on old nom version so config was updated too - allow deprecation needed since config-rs enforces a builder pattern which is not really compatible with the global Config
flxo
requested changes
Jul 31, 2023
Cargo.toml
Outdated
| @@ -17,7 +17,7 @@ license = "MIT" | |||
| name = "rogcat" | |||
| readme = "README.md" | |||
| repository = "https://github.com/flxo/rogcat" | |||
| version = "0.4.6" | |||
| version = "0.4.9-pre" | |||
There was a problem hiding this comment.
This is a huge jump. Think this should be 0.4.7-pre and additionally not part of this pr. I'll fix it.
There was a problem hiding this comment.
I guess I got a bit to excited with those version numbers, I changed it to 0.4.7-pre hope that's fine for your
| @@ -172,6 +172,12 @@ pub fn cli() -> App<'static, 'static> { | |||
| // .long("show-time-diff") | |||
| // .conflicts_with("output") | |||
| // .help( "Show the time difference between the occurence of equal tags in terminal output")) | |||
| .arg(Arg::with_name("dev") | |||
There was a problem hiding this comment.
your request is my command... I'll change it immediately I also removed the unused cli commands
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update nom since the used nom version is about to be deprecated.