Fixes ordering issue with sendEncodings #976
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously with a list of [h, m, l] we were converting them to [l, m, h] which would prevent SVC from working. Unless the encodings were provided in the reversed order.
There was a problem hiding this comment.
I just get dipper in history of this lines and found that your commit revert the 40bde2a.
That is why for sure we need to add @cloudwebrtc in this discussion.
|
@cloudwebrtc any update on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr fixes the issue with incorrect order of RTCRtpEncodings. Currently the order will always be reversed.
For example, a list of [h, m, l] will be turned into [l, m, h] which wouldn't be much of a problem if it wasn't breaking SVC. This fix simply makes sure the order will be maintained.
In addition, here is example how SVC should be enabled https://github.com/w3c/webrtc-svc/blob/main/explainer.md#example-of-setting-a-scalabilitymode and my fix makes it compatible.