-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support unprocessed audio #825
base: main
Are you sure you want to change the base?
Conversation
…agc, high pass filter, suitable for instrument or music input.
@kNoAPP hey, you can use this branch for testing (review ready), I added bypassVoiceProcessing for plugin initialize, in the loopback sample you can turn off audio 3A,
|
Great news! I will give it a test this week and get back to you. |
Testing blocked by webrtc-sdk/webrtc#16. I will resume when possible. |
@cloudwebrtc The changes for iOS & Android sound really good! There's a definite improvement to the instrument audio coming through. A few things found in testing:
If possible, can these be fixed before merging? |
I looked at the audio I/O section of macOS and it seems to be quite different from iOS. still need some time to try to figure it out. |
@cloudwebrtc - We took over the project from kNoAPP, any update about MacOS? |
hey, @jrmilholland, I've had a very busy 2+ months, but I'll have time to work on these issues over the next week. |
Hey @cloudwebrtc, Our client has some additional work he’d like to discuss with you if that’s something you might be interested in. Would you be open to scheduling an audio/video chat? We are in the Pacific time zone but could work with whatever works best for you. I sent you an email as well, but I figured I'd try here as well just in case that lands in a spam filter or something. Thanks! |
I'll try to add unprocessed-audio support to macOS this week. |
Supports unprocessed audio input, such as midi, singing, musical instruments. or specific sound sources.
Keep the original sound quality as much as possible.