Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

android Bluetooth lag, device change event, iOS earpeice #1336

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

mouEsam
Copy link
Contributor

@mouEsam mouEsam commented May 6, 2023

This PR contains:

  • Fix for device change handler being overridden when another flutter engine get registered.
  • Switching twilio audioswitch back to the old fork to solve an issue where Bluetooth devices cause the device to lag and hang very hard on android 11-13 (Not tested on Android 10).
  • Switching the audio mode to VoiceChat when speaker is not activated on iOS

@berger89
Copy link

berger89 commented May 23, 2023

@mouEsam
can you please fix the failed Build for Flutter Android (pull_request) job?

@mouEsam
Copy link
Contributor Author

mouEsam commented May 24, 2023

@berger89 It seems that GitHub actions can't find the specified fork of audioSwitch, however i build and run the example just fine so it might be a missing ssh configuration on the side of the owner of this branch. Nevertheless, I'll look for an alternative fork available through a published repository that solves the Bluetooth lag problem.

@mouEsam
Copy link
Contributor Author

mouEsam commented Aug 8, 2023

All tests pass. @berger89
Would you kindly review this PR? the multiple engines issue is very critical.

@berger89
Copy link

berger89 commented Aug 8, 2023

@cloudwebrtc
looks good to me. Can you confirm this and make a release for it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants