Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Media recorder support for iOS/OSX #1189

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rostopira
Copy link
Collaborator

No description provided.

@rostopira
Copy link
Collaborator Author

rostopira commented Dec 2, 2022

Change to interface should be merged before this PR flutter-webrtc/webrtc-interface#13

@rostopira
Copy link
Collaborator Author

rostopira commented Dec 7, 2022

Well, alternative solution for recording audio should be possible.
But only if we expose setAudioDeviceModule: method of RTCPeerConnectionFactoryBuilder (src here)
But it uses C++ interface.
In other words, some changes would be required in WebRTC sdk.
Would be cool if we make some ability to apply patches for webrtc before build.
Or maybe it's possible to include all headers (including private and c++) in the framework itself?

@rostopira
Copy link
Collaborator Author

Nevermind, I've found where you apply patches
I will try to create patch later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant