Bugfix/ios audio managment on app start #1120
Conversation
PawelBijok
changed the title
PawelBijok
force-pushed
the
bugfix/iOS-audio-managment-on-app-start
branch
from
41af8b8
to
7c41d80
Compare
| @@ -542,6 +542,11 @@ - (void)handleMethodCall:(FlutterMethodCall*)call result:(FlutterResult) result | |||
| } | |||
| [dataChannels removeAllObjects]; | |||
| } | |||
|
|
|||
| #if TARGET_OS_IPHONE | |||
| [[NSNotificationCenter defaultCenter] removeObserver:self]; | |||
There was a problem hiding this comment.
Here is for sure some formatting issue. Please use the same formatting as in edited file.
| #if TARGET_OS_IPHONE | ||
| _preferredInput = AVAudioSessionPortHeadphones; | ||
| _speakerOn = NO; | ||
| [AudioUtils setSpeakerphoneOn:_speakerOn]; | ||
| AVAudioSession *session = [AVAudioSession sharedInstance]; | ||
| [[NSNotificationCenter defaultCenter] addObserver:self selector:@selector(didSessionRouteChange:) name:AVAudioSessionRouteChangeNotification object:session]; | ||
| #endif |
There was a problem hiding this comment.
But what if several peer connection will be created simultaneously?
| _speakerOn = NO; | ||
| [AudioUtils setSpeakerphoneOn:_speakerOn]; | ||
| AVAudioSession *session = [AVAudioSession sharedInstance]; | ||
| [[NSNotificationCenter defaultCenter] addObserver:self selector:@selector(didSessionRouteChange:) name:AVAudioSessionRouteChangeNotification object:session]; |
There was a problem hiding this comment.
I think that at last this part must be left here, because technically we could want to get this notification event without active peer connection.
PawelBijok
force-pushed
the
bugfix/iOS-audio-managment-on-app-start
branch
from
7c41d80
to
a2a21b6
Compare
|
@PawelBijok hey, I added some changes to #1122, it will only operate when RTCAudioSession.isActive, so the problem you described should be fixed, I opened the flutter-webrtc/example app when the zoom meeting was open, and the test results have been Will not affect the voip/music app anymore. |
Fixes #1119