Adding SASL_SSL dependencies for the rdkafka plugin #395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
repeatedly
reviewed
Jan 16, 2020
|
Let's merge same 4 commits into one. |
elafontaine
reviewed
Jan 17, 2020
naumanrana
force-pushed
the
master
branch
6 times, most recently
from
59bf5ee
to
f0212ed
Compare
elafontaine
reviewed
Jan 21, 2020
naumanrana
force-pushed
the
master
branch
3 times, most recently
from
0b1f157
to
c58f818
Compare
|
I think this PR is ready to be merge; @naumanrana 👍 Nice Job |
ganmacs
approved these changes
Jan 23, 2020
repeatedly
reviewed
Jan 27, 2020
Note that the installation of krb5-user is interactive which is why we add export DEBIAN_FRONTEND=noninteractive as per: https://askubuntu.com/questions/1017999/install-kerberos-client-without-interactive-session A post test is then done to make sure that rdkafka is linked against the sasl dependency properly Signed-off-by: naumanrana <nauman.09@gmail.com>
|
Thanks. New images will be published soon;. |
|
Thanks :) eager to use it :). BTW, I was looking at the issue #293 I would like to get your thoughts and know if we could have done something better. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For SASL_SSL with GSSAPI to work with the rdkafka plugin, needed to install a bunch of kerberos related libraries and upgrade the fluent-plugin-kafka to the latest version as rdkafka was not available in 0.7.9.