Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AWS Elasticsearch image #317

Closed
wants to merge 3 commits into from
Closed

Conversation

AdrienKuhn
Copy link

@AdrienKuhn AdrienKuhn commented May 27, 2019

This PR adds debian-awselasticsearch docker image.

AWS ES service require requests signature.

This image contains the aws-elasticsearch-service fluent plugin.

Authentication with AWS ES is done using EC2 instance profile.

Signed-off-by: Adrien Kühn <adrien@kuhn.sh>
@Jaykah
Copy link

Jaykah commented Jul 12, 2019

Is anyone using this in production?

Also, any plans to merge?

Thanks!

@repeatedly
Copy link
Member

Currently, no plan to merge because we have a problem to maintain contributed images.

#293

@danopia
Copy link

danopia commented Sep 9, 2019

I've been using an older version of the same thing in production for at least a year now. Just switched my production to this image because I needed a newer elasticsearch plugin. Dropped it right in 👍

I also replace /fluentd/etc with my own configuration at the Kubernetes level, so that I can roll out new configs without making new images. Works well, but sadly means I can't directly vouch for the config presented here.

@gatolim
Copy link

gatolim commented Oct 1, 2019

@AdrienKuhn thanks for coming up with the repo. I am new to the docker world and was playing around this. I have my ES set up in AWS and have docker for window set up locally. I cloned your repo and docker build the debian-awselasticsearch image however when I try to apply the image using fluentd-daemonset-awselasticsearch-rbac.yml I have the following error:
[FATAL tini (6)] exec /fluentd/entrypoint.sh failed: No such file or directory

I verified that the build steps does copy this .sh file and the file existed in my build folder. Am I missing something ?

@AdrienKuhn
Copy link
Author

AdrienKuhn commented Oct 5, 2019

@gatolim I tried to apply the fluentd-daemonset-awselasticsearch-rbac.yml file on my side and I didn't encounter any issue.

I used the following (v1.7) image for test purposes: krewh/fluentd-awselasticsearch.
We are also using the 1.4 version (deployed through a custom Helm chart) in a dev cluster.

@gatolim
Copy link

gatolim commented Oct 9, 2019

Thanks @AdrienKuhn, I ended up building my own image. I encountered the same problem while using my own and it turns out to be the end line char ('\r\n') difference between window and linux in the .sh file. I suspected it was the same cause when I use yours.

@wcarlsen
Copy link
Contributor

We ended up using this proxy (https://github.com/abutaha/aws-es-proxy) as a sidecar, which allows us to use on of the pre built images of this repos. Works flawlessly, but the proxy image development is rather stale.

@Nuru
Copy link

Nuru commented Nov 18, 2019

We ended up using this proxy (https://github.com/abutaha/aws-es-proxy) as a sidecar, which allows us to use on of the pre built images of this repos. Works flawlessly, but the proxy image development is rather stale.

@wcarlsen Did you really get aws-es-proxy to work flawlessly? Last time I tried it I had to reject it because if it encountered a 403 or 302 status code from Elasticsearch it would just swallow it and return an empty 200 to the caller. How did you fix this, or did you just decide it was acceptable behavior?

@wcarlsen
Copy link
Contributor

wcarlsen commented Nov 18, 2019

@Nuru we probably shouldn't continue this here (hint: email me). But I wasn't aware of this behavior. I think it is a trade off between maintaining a fluentd image. We are currently investigating when we would expect to get a 302 or 403 from AWS ES. Maybe you have experience with this or have a better overview of how big a problem this actually is?

@AdrienKuhn AdrienKuhn closed this Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pending Can't merge by some reason
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants