Support for AMQP #248
Closed
Support for AMQP #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
mmailhos
force-pushed
the
add-amqp
branch
4 times, most recently
from
57adb80
to
5dcc267
Compare
Signed-off-by: Mathieu Mailhos <mathieu@datarepublic.com>
|
Hi, I really need that PR. Please merge :-) |
|
Out of my own curiosity, any reason this PR doesn't use the giraffi based fluent-plugin-amqp - I'm a contributor on that project and am about to start deploying the plugin onto our own kubernetes clusters so if you're aware of a known problem with it, i'll need to go fix it :-) |
|
Any news concerning this PR ? |
|
Any news? |
|
Still no merge ? |
|
Yes. Currently, we don't want to merge such patches because it is not good for users. We need to find good way for maintaining third party images. |
|
I just opened new issue for current concern: #293 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.