ship logs to loomsystems #227
Conversation
Signed-off-by: yatirdagan <yatir1230@gmail.com>
Signed-off-by: yatirdagan <yatir1230@gmail.com>
Signed-off-by: yatirdagan <yatir1230@gmail.com>
Signed-off-by: yatirdagan <yatir1230@gmail.com>
|
Do other users want this image? |
|
Hi,
Loom Systems is used by many customers, including several fortune-500
companies.
We have implemented this PR after being requested by several of our
customers.
We're happy to provide whatever information you need to decide in favor of
including us.
Thanks
בתאריך יום ג׳, 4 בדצמ׳ 2018 ב-16:53 מאת Masahiro Nakagawa <
notifications@github.com>:
… Do other users want this image?
I'm not sure loomsystems is popular in k8s environemnt so
I can't judge loomsystems destination should be supported or not in
official images.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#227 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AaGSUzzkjldR6MQ8hCznYGzqGcAhAVcVks5u1oxQgaJpZM4YrHaF>
.
|
fluent-kubernetes-loomsystems.yaml
Outdated
| - name: FLUENT_UID | ||
| value: "0" | ||
| - name: LOOM_RECIEVER_HOST | ||
| value: "129.213.38.169" |
There was a problem hiding this comment.
Is this the correct IP? It doesn't resolve to any domain name.
fluent-kubernetes-loomsystems.yaml
Outdated
| imagePullPolicy: Always | ||
| env: | ||
| - name: FLUENT_UID | ||
| value: "0" |
There was a problem hiding this comment.
In the other images we don't set this by default but leave it to the user. Don't think we should be changing that here.
fluent-kubernetes-loomsystems.yaml
Outdated
| - name: LOOM_RECIEVER_HOST | ||
| value: "129.213.38.169" | ||
| - name: LOOM_RECIEVER_SSL_PORT | ||
| value: "9999" |
There was a problem hiding this comment.
Are these ports correct? They are non-standard ports.
There was a problem hiding this comment.
fixed, these setting will defined by the user
| imagePullPolicy: Always | ||
| env: | ||
| - name: LOOM_RECIEVER_HOST | ||
| value: "{{RECEIVER HOST}}" |
There was a problem hiding this comment.
If these are meant to be set by the user we should mention in the docs that they are expected to set these.
|
BTW, we dropped v0.12 and alpine version support before: https://github.com/fluent/fluentd-kubernetes-daemonset#alpine-linux-this-is-deprecated-use-debian-images-instead And you need to add you to maintainer list: https://github.com/fluent/fluentd-kubernetes-daemonset#maintainers |
No description provided.