adding datadog #158
Open
adding datadog #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
segfault
force-pushed
the
add-datadog
branch
2 times, most recently
from
435b9a3
to
35cec1a
Compare
|
I've tested this and I'm currently running this in two k8s clusters. Beyond a rebase is there anything else I should do? |
Signed-off-by: Mark Guzman <segfault@hasno.info>
Signed-off-by: Mark Guzman <segfault@hasno.info>
segfault
force-pushed
the
add-datadog
branch
from
22d5222
to
a17ebb2
Compare
|
the original PR for datadog did edit the templates... just takes ages to get things merged so just closed the PR |
|
What would it take to rebase and merge this one? I'm interested in using Datadog with this and would prefer not needing to write it myself. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added datadog support. Hopefully I've followed the established pattern correctly. I see /pull/85 exists but attempted to edit the outputs instead of the templates, this PR edited the templates.