out_rdkafka2: add patch for new version of rdkafka #505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ttych
commented
Dec 9, 2023
| @@ -509,7 +509,6 @@ You need to install rdkafka gem. | |||
| partition_key (string) :default => 'partition' | |||
| partition_key_key (string) :default => 'partition_key' | |||
| message_key_key (string) :default => 'message_key' | |||
| default_topic (string) :default => nil | |||
There was a problem hiding this comment.
This line in conf block appears twice,
I just removed one.
Signed-off-by: Thomas Tych <thomas.tych@gmail.com>
|
I just see #500, and also, waterdrop encapsulation for rdkafka is just for producer side. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All PR are failing now because of rdkafka gem update.
The current code works with rdkafka 0.12.0,
and in 0.14.0 (there is no 0.13.0), the
Rdkafka::Producerimplementation has changed,no more
@clientandRdkafka::Producer::Client,now there is a
@native_clientandRdkafka::NativeKafka.No update on this part of the code between 0.14.0 and 0.15.0.
There is a constraint in the out_rdkafka2, on the
Rdkafka::Producer#close, to add a timeout,which is not part of the standard gem.
I try to update this behavior since following the current way to patch.
Thanks.