Added possibility not to forward _make_packet errors #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Victor Gavro <vgavro@gmail.com>
Signed-off-by: Victor Gavro <vgavro@gmail.com>
vgavro
force-pushed
the
no_forward_make_packet_error
branch
from
786ddad
to
0468c7d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if there is some error in
FluentSender._make_packet- it's forwarded to fluent host instead of adding possibility to get local exception before forward. Added option for thisforward_packet_error- which defaults toTruefor backward-compatibility.Also
EventTimecreation (for nanoseconds precision) moved to_make_packet- just to more easily implement some custom logic for bulk sending..