Fix uri conversion and improve readme #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ris, because the if-condition never came true
- add info that migrations need to run - add info on how to fix permission error when generating the preview url - add info on how previewers can actually use that package
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was done?
I fixed the ConvertUriImplementation.
As far as I can tell, the if condition never returned true, because the second part was always false. I removed the second part and now it works. I also checked that this doesn't impact the uri conversion in the normal live frontend view.
I'm not entirely certain this is the right way to correct that problem, but it does work. Please have a look :)
I added more information to the Readme.
For me it was unclear how to fix the error I was getting and how to actually use the package, so I added information on that. I also added a note that there are migrations that need to run, just so you can see that right away in the readme and not have to go to your workspace module first to find it's not working anymore.
Just trying to make everyone's life easier. If you'd like me to change the wording or anything, just let me know.