Skip to content

Commit

Permalink
Merge pull request #39 from florianv/yahoo
Browse files Browse the repository at this point in the history
Documentation and tests updates
  • Loading branch information
florianv committed Dec 18, 2017
2 parents 3b0517d + 8b9fd6d commit 594487c
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 6 deletions.
1 change: 1 addition & 0 deletions .travis.yml
Expand Up @@ -5,6 +5,7 @@ php:
- 5.6
- 7.0
- 7.1
- 7.2

sudo: false

Expand Down
4 changes: 2 additions & 2 deletions README.md
Expand Up @@ -7,7 +7,7 @@
[![Scrutinizer](https://img.shields.io/scrutinizer/g/florianv/laravel-swap.svg?style=flat-square)](https://scrutinizer-ci.com/g/florianv/laravel-swap)
[![Version](http://img.shields.io/packagist/v/florianv/laravel-swap.svg?style=flat-square)](https://packagist.org/packages/florianv/laravel-swap)

**Swap** allows you to retrieve currency exchange rates from various services such as [Fixer](http://fixer.io) or [Yahoo](https://finance.yahoo.com/) and optionally cache the results.
**Swap** allows you to retrieve currency exchange rates from various services such as [Fixer](http://fixer.io) or [Google](https://google.com/) and optionally cache the results.

<br /><br />

Expand Down Expand Up @@ -92,13 +92,13 @@ Here is the list of the currently implemented services.
| [Google](http://www.google.com/finance) | * | * | No |
| [Open Exchange Rates](https://openexchangerates.org) | USD (free), * (paid) | * | Yes |
| [Xignite](https://www.xignite.com) | * | * | Yes |
| [Yahoo](https://finance.yahoo.com) | * | * | No |
| [WebserviceX](http://www.webservicex.net/ws/default.aspx) | * | * | No |
| [National Bank of Romania](http://www.bnr.ro) | RON | * | No |
| [Central Bank of the Republic of Turkey](http://www.tcmb.gov.tr) | * | TRY | No |
| [Central Bank of the Czech Republic](http://www.cnb.cz) | * | CZK | No |
| [Russian Central Bank](http://http://www.cbr.ru) | * | RUB | Yes |
| [currencylayer](https://currencylayer.com) | USD (free), * (paid) | * | Yes |
| [Cryptonator](https://www.cryptonator.com) | * Crypto (Limited standard currencies) | * Crypto (Limited standard currencies) | No |
| Array | * | * | Yes |

## Credits
Expand Down
8 changes: 4 additions & 4 deletions doc/readme.md
Expand Up @@ -79,11 +79,11 @@ If you wish to use different services, you can modify the `services` configurati
// app/config/swap.php
'services' => [
'fixer' => true,
'yahoo' => true,
'google' => true,
]
```

With this configuration, Swap will first use [Fixer.io](http://fixer.io) and fallback to [Yahoo](https://finance.yahoo.com) in case of failure.
With this configuration, Swap will first use [Fixer.io](http://fixer.io) and fallback to [Google](https://google.com) in case of failure.

> You can consult the list of the supported services and their options [here](#supported-services)
Expand Down Expand Up @@ -249,7 +249,7 @@ Here is the complete list of supported services and their possible configuration
],
'webservicex' => true,
'xignite' => ['token' => 'token'],
'yahoo' => true,
'russian_central_bank' => true
'russian_central_bank' => true,
'cryptonator' => true
]
```
1 change: 1 addition & 0 deletions tests/SwapServiceProviderTest.php
Expand Up @@ -75,6 +75,7 @@ public function testAllServices()
'xignite' => ['token' => 'token'],
'yahoo' => true,
'russian_central_bank' => true,
'cryptonator' => true,
]);

$this->assertInstanceOf(Chain::class, $this->app['swap.chain']);
Expand Down

0 comments on commit 594487c

Please sign in to comment.