FlxSprite.isSimpleRender has huge side effects and causes a batch flushes #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flush on EVERY call. Make the function simple and readable, and defer render state handling to where we already have it, in FlxSprite.draw(). Tested on my own games that uses rotating sprites and 1 shader. Blending and other fancyness not tested, but I think it will work. Fixes flixel-gdx#78
|
Your fix doesn't work. Try to run GLES20 example 1-3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FlxSprite.isSimpleRender has huge side effects and causes a batch flush on EVERY call.
Make the function simple and readable, and defer render state
handling to where we already have it, in FlxSprite.draw().
Tested on my own games that uses rotating sprites and 1 shader.
Blending and other fancyness not tested, but I think it will work.
Fixes #78