Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FL-3816] Text Box rework #3642

Merged
merged 16 commits into from
May 20, 2024
Merged

[FL-3816] Text Box rework #3642

merged 16 commits into from
May 20, 2024

Conversation

gornekich
Copy link
Member

@gornekich gornekich commented May 8, 2024 •
edited by skotopes

What's new

  • Calculate text offsets dynamically while scrolling to optimize memory consumption

Verification

  • All text box screens work as before
  • NFC app doesn't crash on MF Classic More info scene

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@github-actions GitHub Actions
Copy link

github-actions bot commented May 8, 2024 •
edited

Compiled f7 firmware for commit d8b06baf:

@hedger hedger added UI Affects UI Core+Services HAL, furi & core system services labels May 13, 2024
@gornekich gornekich marked this pull request as draft May 15, 2024 18:55
@gornekich gornekich marked this pull request as ready for review May 19, 2024 14:03
@gornekich gornekich requested a review from nminaylov as a code owner May 19, 2024 14:03
@skotopes skotopes merged commit d5339f8 into dev May 20, 2024
11 checks passed
@skotopes skotopes deleted the gornek/3816_text_box_rework branch May 20, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skotopes skotopes skotopes approved these changes

@DrZlo13 DrZlo13 Awaiting requested review from DrZlo13 DrZlo13 is a code owner

@hedger hedger Awaiting requested review from hedger hedger is a code owner

@gsurkov gsurkov Awaiting requested review from gsurkov gsurkov is a code owner

@nminaylov nminaylov Awaiting requested review from nminaylov nminaylov is a code owner

Assignees
No one assigned
Labels
Core+Services HAL, furi & core system services UI Affects UI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gornekich @skotopes @hedger