Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Icons: compression fixes & larger dimension support #3564

Merged
merged 53 commits into from
May 20, 2024
Merged

Icons: compression fixes & larger dimension support #3564

merged 53 commits into from
May 20, 2024

Conversation

hedger
Copy link
Member

@hedger hedger commented Apr 2, 2024 •
edited by skotopes

What's new

  • gui: icon API improvements: getters for single frames
  • gui: increased max supported dimensions for icons to 65535x65535 (from 255x255)
  • gui, compression: unified heatshrink usage, added extra validations for icon decompression results
  • gui, compression: added support for decoding icons larger than decomp buffer size (1k), using dynamic allocations if needed
  • unit_tests: reworked to run tests as separate modules from SD card
  • fbt: added module filtering for firmware dist package
  • loader: api: added md5_calc, bt_keys_storage, pulse_glue, varint

Verification

  • Everything should work as before
  • You can create code that uses large images

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@flipperdevices flipperdevices deleted a comment from github-actions bot Apr 2, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 2, 2024 •
edited

Compiled f7 firmware for commit 8c1b68ab:

@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@skotopes skotopes marked this pull request as ready for review April 19, 2024 11:04
@hedger hedger changed the title Hedger/icomp fixes Icons: compression fixes & bigger dimension Apr 23, 2024
@hedger hedger added UI Affects UI Core+Services HAL, furi & core system services labels Apr 23, 2024
@hedger hedger changed the title Icons: compression fixes & bigger dimension Icons: compression fixes & larger dimension support Apr 23, 2024
DrZlo13
DrZlo13 reviewed May 13, 2024
View reviewed changes
lib/toolbox/compress.c Outdated Show resolved Hide resolved
hedger and others added 17 commits May 17, 2024 20:07
@hedger
investigating unit test failures
4390492
@hedger
investigating unit test failures
d70e9c1
@hedger
investigating unit test failures
52f79a5
@hedger
investigating unit test failures
d1619db
@skotopes
Merge branch 'dev' into hedger/icomp_fixes
8e4c614
@skotopes
UnitTests: move all tests into plugins, brakes testing
31b322c
@skotopes
UnitTests: add plugin API and update plugin entrypoints
d63aace
@skotopes
UniTests: Test runner that works with plugins
7ef041b
@hedger
fbt: extra filtering for extapps to include in build
c875c2e
@skotopes
UnitTests: filter tests by name
64e695f
@hedger
loader: restored API table for unit_test build config
cc9d928
@skotopes
Add various missing symbols to API table
6ebf6e5
@skotopes
UnitTest: fail on plugin load error
b9add3d
@skotopes
UnitTests: cleanup plugin api and reporting
f5f1fe6
@hedger
unit_tests: composite resolver
0413ea5
@skotopes
UnitTests: remove unused declaration
6074036
@hedger
unit_tests, nfc: moved mock nfc implementation to libnfc
03ff9b8
@hedger hedger added the App Loader FAP loader + API-related label May 19, 2024
@skotopes skotopes merged commit 9e42e00 into dev May 20, 2024
11 checks passed
@skotopes skotopes deleted the hedger/icomp_fixes branch May 20, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DrZlo13 DrZlo13 DrZlo13 left review comments

@Willy-JL Willy-JL Willy-JL left review comments

@skotopes skotopes skotopes approved these changes

@gsurkov gsurkov Awaiting requested review from gsurkov gsurkov is a code owner

@nminaylov nminaylov Awaiting requested review from nminaylov nminaylov is a code owner

@gornekich gornekich Awaiting requested review from gornekich gornekich is a code owner

@Astrrra Astrrra Awaiting requested review from Astrrra Astrrra is a code owner

@Skorpionm Skorpionm Awaiting requested review from Skorpionm Skorpionm is a code owner

Assignees
No one assigned
Labels
App Loader FAP loader + API-related Core+Services HAL, furi & core system services UI Affects UI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@hedger @skotopes @DrZlo13 @Willy-JL